buck2_events: refactor scribe to remote sink #686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@cjhopman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@cjhopman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Rename the scribe sink to a more generic name Remote Event Sink. This abstracts away from the implementation behind the sink, which is Srcibe within Meta. Prepare for a future Remote Sink implementation for OSS use case.
sluongng
force-pushed
the
sluongng/refactor-scribe-sink
branch
from
a8f052d to
f5bf0bb
Compare
|
cc: @JakobDegen This one is a simple rename refactoring. Though I don't know if you have other references internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the scribe sink to a more generic name Remote Event Sink.
This abstracts away from the implementation behind the sink, which is
Srcibe within Meta.
Prepare for a future Remote Sink implementation for OSS use case.